Page MenuHomePhabricator

sslutil: migrate to hashutil.sha1 instead of hashlib.sha1

Authored by durin42 on Jan 13 2020, 5:48 PM.



This is a straight-line replacement like the others, but I split it
out since it's used in a network context and I'm not sure this is
appropriate (we should probably drop support for sha1
fingerprints over TLS) and wanted this to be easily dropped.

Diff Detail

rHG Mercurial
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Jan 13 2020, 5:48 PM
indygreg accepted this revision.Jan 13 2020, 11:24 PM
indygreg added a subscriber: indygreg.

Yeah, the new SHA-1 routine probably doesn't matter in this context. And we should probably drop support for SHA-1 certificate fingerprint verification. But consistency in using our SHA-1 wrapper is worth it, IMO.

This revision is now accepted and ready to land.Jan 13 2020, 11:24 PM