( )⚙ D7872 lfs: add "bytes" as the unit to the upload/download progress bar

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D7872

lfs: add "bytes" as the unit to the upload/download progress bar
ClosedPublic

Authored by mharbison72 on Jan 14 2020, 12:47 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG05881d002cb2: lfs: add "bytes" as the unit to the upload/download progress bar
Summary

Facebook also passes util.bytecount() as a pretty formatter here, but our
progress bar doesn't support that.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Jan 14 2020, 12:47 PM
pulkit accepted this revision.Jan 14 2020, 4:07 PM
This revision is now accepted and ready to land.Jan 14 2020, 4:07 PM

Revision Contents
Changeset List

PathPackages
Mhgext/lfs/blobstore.py (4 lines)

Diff 19272

hgext/lfs/blobstore.py

0.1, 0.1,
transfer, transfer,
(), (),
sorted(objects, key=lambda o: o.get(b'oid')), sorted(objects, key=lambda o: o.get(b'oid')),
) )
else: else:
oids = transfer(sorted(objects, key=lambda o: o.get(b'oid'))) oids = transfer(sorted(objects, key=lambda o: o.get(b'oid')))
with self.ui.makeprogress(topic, total=total) as progress: with self.ui.makeprogress(
topic, unit=_(b"bytes"), total=total
) as progress:
progress.update(0) progress.update(0)
processed = 0 processed = 0
blobs = 0 blobs = 0
for _one, oid in oids: for _one, oid in oids:
processed += sizes[oid] processed += sizes[oid]
blobs += 1 blobs += 1
progress.update(processed) progress.update(processed)
self.ui.note(_(b'lfs: processed: %s\n') % oid) self.ui.note(_(b'lfs: processed: %s\n') % oid)