Page MenuHomePhabricator

lfs: avoid quadratic performance in processing server responses
ClosedPublic

Authored by mharbison72 on Jan 14 2020, 11:09 PM.

Details

Summary

This is also adapted from the Facebook repo[1]. Unlike there, we were already
reading the download stream in chunks and immediately writing it to disk, so we
basically avoided the problem on download. There shouldn't be a lot of data to
read on upload, but it's better to get rid of this pattern.

[1] https://github.com/facebookexperimental/eden/commit/82df66ffe97e21f3ee73dfec093c87500fc1f6a7

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Jan 14 2020, 11:09 PM
pulkit accepted this revision.Jan 15 2020, 7:15 AM
This revision is now accepted and ready to land.Jan 15 2020, 7:15 AM