Page MenuHomePhabricator

rebase: define base in only place in defineparents()

Authored by martinvonz on Jan 16 2020, 3:10 AM.


Diff Detail

rHG Mercurial
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jan 16 2020, 3:10 AM
pulkit added a subscriber: pulkit.Jan 27 2020, 9:40 AM
pulkit added inline comments.

I am not sure why we are doing bases[i] = bases[0] here? (TBH I didn't try to understand the whole logic, mostly only the diff)

martinvonz added inline comments.Jan 27 2020, 9:43 AM

Doing it only for consistency with newps. bases and newps should be kept in sync (we don't do that in one other place, but that's pretty weird, IMO). So I think it's clearer this way even though it's unnecessary.

martinvonz updated this revision to Diff 19698.Jan 29 2020, 7:56 PM
pulkit accepted this revision.Jan 30 2020, 9:36 AM
This revision is now accepted and ready to land.Jan 30 2020, 9:36 AM
This revision was automatically updated to reflect the committed changes.