Page MenuHomePhabricator

lfs: move the initialization of the upload request into the try block
ClosedPublic

Authored by mharbison72 on Jan 21 2020, 1:37 PM.

Details

Summary

This (almost) guarantees that the file is closed in the case of an exception.
The one hole is if the seek(SEEK_END)/tell()/seek(0) sequence fails. But
that's going to go away when subclassing httpconnection.httpsendfile to fix
the worker problem, so I'm not going to worry too much. (And that class appears
to have the same problem.)

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.