Page MenuHomePhabricator

py3: catch AttributeError too with ImportError
ClosedPublic

Authored by pulkit on Tue, Jan 21, 4:47 PM.

Details

Summary

Looks like py3 raises AttributeError instead of ImportError. This is caught on
windows.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit created this revision.Tue, Jan 21, 4:47 PM
marmoute accepted this revision.Wed, Feb 5, 6:21 PM
marmoute added a subscriber: marmoute.

Sounds reasonable

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.