This is an archive of the discontinued Mercurial Phabricator instance.

py3: catch AttributeError too with ImportError
ClosedPublic

Authored by pulkit on Jan 21 2020, 4:47 PM.

Details

Summary

Looks like py3 raises AttributeError instead of ImportError. This is caught on
windows.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

pulkit created this revision.Jan 21 2020, 4:47 PM
marmoute accepted this revision.Feb 5 2020, 6:21 PM
marmoute added a subscriber: marmoute.

Sounds reasonable

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.