Page MenuHomePhabricator

copies: move early return in mergecopies() earlier
ClosedPublic

Authored by martinvonz on Jan 23 2020, 1:44 AM.

Details

Summary

It wasn't obvious that the early return happened only when there are
no copies. That is the case, however, because if fullcopy is empty,
then so is copies1 and copies2, and then so is inversecopies1
and inversecopies2, and then so is allsources, and then so is
copy, diverge and renamedelete.

By moving the early return earlier, we also avoid calculating the set
of added files from the base to each side.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.