Page MenuHomePhabricator

clean: check that there are no conflicts after
ClosedPublic

Authored by martinvonz on Jan 24 2020, 12:36 PM.

Details

Summary

As noted by Pulkit, there should never be any conflicts after doing a
clean update, so hg.clean() should never return True. Let's check
that assertion instead to clarify the code. The callers will now get a
None instead of a False returned, but that should be fine (both
result in a 0 exit status).

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

martinvonz created this revision.Jan 24 2020, 12:36 PM
pulkit accepted this revision.Jan 24 2020, 5:10 PM
This revision is now accepted and ready to land.Jan 24 2020, 5:10 PM
This revision was automatically updated to reflect the committed changes.