This is an archive of the discontinued Mercurial Phabricator instance.

phabricator: handle non-JSON response gracefully
ClosedPublic

Authored by mjpieters on Sep 22 2017, 1:55 PM.
Tags
None
Subscribers
None

Details

Reviewers
quark
Group Reviewers
Restricted Project
Commits
rFBHGX694bf743c160: phabricator: handle non-JSON response gracefully
Summary

Tested by trying to connect to a non-phabricator URL that responds with HTML to
a POST request and by trying to run hg ssl when not on the corp network.

Depends on D799

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mjpieters created this revision.Sep 22 2017, 1:55 PM
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 22 2017, 1:55 PM
quark accepted this revision.Sep 22 2017, 1:58 PM
This revision is now accepted and ready to land.Sep 22 2017, 1:58 PM
This revision was automatically updated to reflect the committed changes.