This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8019

rust-node: avoid meaningless read at the end of odd prefix
ClosedPublic

Authored by gracinet on Jan 27 2020, 2:35 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGbe52b7372ec2: rust-node: avoid meaningless read at the end of odd prefix
Summary

This should be heavily factored out by the CPU branch predictor
anyway.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

gracinet created this revision.Jan 27 2020, 2:35 PM
gracinet added a commit: rHGbe52b7372ec2: rust-node: avoid meaningless read at the end of odd prefix.Jan 28 2020, 6:31 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGbe52b7372ec2: rust-node: avoid meaningless read at the end of odd prefix (authored by gracinet). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mrust/hg-core/src/revlog/node.rs (1 line)

Diff 19648

rust/hg-core/src/revlog/node.rs

} }
} }
/// Retrieve the `i`th half-byte from the prefix. /// Retrieve the `i`th half-byte from the prefix.
/// ///
/// This is also the `i`th hexadecimal digit in numeric form, /// This is also the `i`th hexadecimal digit in numeric form,
/// also called a [nybble](https://en.wikipedia.org/wiki/Nibble). /// also called a [nybble](https://en.wikipedia.org/wiki/Nibble).
pub fn get_nybble(&self, i: usize) -> u8 { pub fn get_nybble(&self, i: usize) -> u8 {
assert!(i < self.len());
get_nybble(self.buf, i) get_nybble(self.buf, i)
} }
} }
/// A shortcut for full `Node` references /// A shortcut for full `Node` references
impl<'a> From<&'a Node> for NodePrefixRef<'a> { impl<'a> From<&'a Node> for NodePrefixRef<'a> {
fn from(node: &'a Node) -> Self { fn from(node: &'a Node) -> Self {
NodePrefixRef { NodePrefixRef {