This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8047

rust-dirstatemap: add missing @propertycache
ClosedPublic

Authored by Alphare on Jan 30 2020, 9:09 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHG7f5410dfc8a6: rust-dirstatemap: add missing @propertycache
Summary

While investigating a regression on hg update performance introduced by the
Rust dirstatemap, two missing @propertycache were identified when comparing
against the Python implementation. This adds back the first one, that has
no observable impact on behavior. The second one (nonnormalset) is going to
be more involved, as the caching has to be done from the Rust side of things.

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.Jan 30 2020, 9:09 AM
Alphare added a child revision: D8048: rust-dirstatemap: cache non normal and other parent set.Jan 30 2020, 9:09 AM
Alphare retitled this revision from rust-dirstate: add missing @propertycache to rust-dirstatemap: add missing @propertycache.
Alphare added a commit: rHG7f5410dfc8a6: rust-dirstatemap: add missing @propertycache.Feb 3 2020, 11:06 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG7f5410dfc8a6: rust-dirstatemap: add missing @propertycache (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.
jamsebondeea added a subscriber: jamsebondeea.Mar 10 2022, 8:52 AM

Excellent writing. This write-up has effects on many critical troubles your contemporary society. Most of us cannot be uninvolved to help most of these troubles. That write-up allows good ideas in addition to methods. Incredibly beneficial in addition to realistic. Soccer drills

Revision Contents
Changeset List

PathPackages
Mmercurial/dirstate.py (2 lines)

Diff 19711

mercurial/dirstate.py

self._rustmap self._rustmap
return self.identity return self.identity
@property @property
def nonnormalset(self): def nonnormalset(self):
nonnorm, otherparents = self._rustmap.nonnormalentries() nonnorm, otherparents = self._rustmap.nonnormalentries()
return nonnorm return nonnorm
@property @propertycache
def otherparentset(self): def otherparentset(self):
nonnorm, otherparents = self._rustmap.nonnormalentries() nonnorm, otherparents = self._rustmap.nonnormalentries()
return otherparents return otherparents
@propertycache @propertycache
def dirfoldmap(self): def dirfoldmap(self):
f = {} f = {}
normcase = util.normcase normcase = util.normcase
for name in self._dirs: for name in self._dirs:
f[normcase(name)] = name f[normcase(name)] = name
return f return f