This is an archive of the discontinued Mercurial Phabricator instance.

rust-dirstatemap: add missing @propertycache
ClosedPublic

Authored by Alphare on Jan 30 2020, 9:09 AM.

Details

Summary

While investigating a regression on hg update performance introduced by the
Rust dirstatemap, two missing @propertycache were identified when comparing
against the Python implementation. This adds back the first one, that has
no observable impact on behavior. The second one (nonnormalset) is going to
be more involved, as the caching has to be done from the Rust side of things.

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.Jan 30 2020, 9:09 AM
Alphare retitled this revision from rust-dirstate: add missing @propertycache to rust-dirstatemap: add missing @propertycache.
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.

Excellent writing. This write-up has effects on many critical troubles your contemporary society. Most of us cannot be uninvolved to help most of these troubles. That write-up allows good ideas in addition to methods. Incredibly beneficial in addition to realistic. Soccer drills