Page MenuHomePhabricator

rust-dirstatemap: update call sites from Python
AbandonedPublic

Authored by Alphare on Thu, Jan 30, 9:10 AM.

Details

Reviewers
marmoute
Group Reviewers
hg-reviewers

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.Thu, Jan 30, 9:10 AM
marmoute requested changes to this revision.Fri, Feb 7, 3:14 PM
marmoute added a subscriber: marmoute.

This is straightforward, however having some performance number would be great.

This revision now requires changes to proceed.Fri, Feb 7, 3:14 PM

This is straightforward, however having some performance number would be great.

This is simply an API change related to the performance improvements in previous patches. Is this commit where we should put those performance numbers?

pulkit added a subscriber: pulkit.Mon, Feb 10, 1:01 PM

This is straightforward, however having some performance number would be great.

This is simply an API change related to the performance improvements in previous patches. Is this commit where we should put those performance numbers?

Yes, it's fine to put performance numbers in last patch in series.

Also these changes should ideally be folded into patches where corresponding rust changes are done.

Alphare abandoned this revision.Mon, Feb 10, 4:11 PM

Folded into the previous changeset, with an amended commit message