This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8053

pyoxidizer: use `legacy_windows_stdio` on Windows
ClosedPublic

Authored by mharbison72 on Jan 30 2020, 7:56 PM.

Details

Reviewers
marmoute
pulkit
Group Reviewers
hg-reviewers
Commits
rHGcd8f248fead4: pyoxidizer: use `legacy_windows_stdio` on Windows
Summary

The C executable sets this too, otherwise no output shows up (when paging?).
There is also legacy_windows_fs_encoding, but I'm not setting that for now
because the C executable doesn't either.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Jan 30 2020, 7:56 PM
marmoute accepted this revision.Feb 7 2020, 1:41 PM
marmoute added a subscriber: marmoute.

I guess this is right ? We hase have similar fallback to legacy mode in the python code.

pulkit accepted this revision.Feb 10 2020, 12:33 PM
This revision is now accepted and ready to land.Feb 10 2020, 12:33 PM
mharbison72 added a commit: rHGcd8f248fead4: pyoxidizer: use `legacy_windows_stdio` on Windows.Feb 10 2020, 1:01 PM
Closed by commit rHGcd8f248fead4: pyoxidizer: use `legacy_windows_stdio` on Windows (authored by mharbison72). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/packaging/pyoxidizer.bzl (1 line)

Diff 20052

contrib/packaging/pyoxidizer.bzl

code = "import hgdemandimport; hgdemandimport.enable(); from mercurial import dispatch; dispatch.run()" code = "import hgdemandimport; hgdemandimport.enable(); from mercurial import dispatch; dispatch.run()"
config = PythonInterpreterConfig( config = PythonInterpreterConfig(
raw_allocator = "system", raw_allocator = "system",
run_eval = code, run_eval = code,
# We need this to make resourceutil happy, since it looks for sys.frozen. # We need this to make resourceutil happy, since it looks for sys.frozen.
sys_frozen = True, sys_frozen = True,
legacy_windows_stdio = True,
) )
exe = dist.to_python_executable( exe = dist.to_python_executable(
name = "hg", name = "hg",
config = config, config = config,
) )
# Use setup.py install to build Mercurial and collect Python resources to # Use setup.py install to build Mercurial and collect Python resources to