This is an archive of the discontinued Mercurial Phabricator instance.

absorb: graduate -i flag from experimental
ClosedPublic

Authored by martinvonz on Jan 31 2020, 12:26 PM.

Details

Summary

The interactive mode seems to work well. I have previously thought
that -i should be what -e does, but the current behavior matches
what other -i flags do (select a subset of the hunks), so I think
that is what we want.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Jan 31 2020, 12:26 PM
pulkit accepted this revision.Jan 31 2020, 6:31 PM
pulkit added a subscriber: pulkit.

The whole absorb extension is experimental, so even if we want to change -i somehow in future, this looks fine.

This revision is now accepted and ready to land.Jan 31 2020, 6:31 PM
This revision was automatically updated to reflect the committed changes.