( )⚙ D8092 hghave: cache the result of gethgversion

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8092

hghave: cache the result of gethgversion
ClosedPublic

Authored by jcristau on Feb 7 2020, 10:02 AM.

Details

Reviewers
marmoute
pulkit
Group Reviewers
hg-reviewers
Commits
rHGe48a996d12bc: hghave: cache the result of gethgversion
rHG8607dc2aa686: hghave: cache the result of gethgversion
Summary

hghave --test-features calls it 90 times, each one calling hg --version
which takes a tenth of a second on my workstation, adding up to about
10s win on test-hghave.t.

Fixes https://bugs.debian.org/939756

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

jcristau created this revision.Feb 7 2020, 10:02 AM
marmoute added a subscriber: marmoute.Feb 7 2020, 1:52 PM

I can confirm the perf win:

before: 10.687 seconds
after 3.6.19 seconds

marmoute accepted this revision.Feb 7 2020, 1:52 PM
pulkit added a subscriber: pulkit.Feb 7 2020, 3:21 PM

This is fixing some debian packaging issue, so is it targeted for stable branch?

jcristau added a comment.Feb 7 2020, 3:33 PM

It fixes a longstanding issue in tests, it's not particularly urgent IMO.

pulkit accepted this revision.Feb 7 2020, 4:02 PM
This revision is now accepted and ready to land.Feb 7 2020, 4:02 PM
jcristau added a commit: rHG8607dc2aa686: hghave: cache the result of gethgversion.Feb 7 2020, 4:37 PM
Closed by commit rHG8607dc2aa686: hghave: cache the result of gethgversion (authored by jcristau). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/hghave.py (10 lines)

Diff 19985

tests/hghave.py

import _lsprof import _lsprof
_lsprof.Profiler # silence unused import warning _lsprof.Profiler # silence unused import warning
return True return True
except ImportError: except ImportError:
return False return False
def gethgversion(): def _gethgversion():
m = matchoutput('hg --version --quiet 2>&1', br'(\d+)\.(\d+)') m = matchoutput('hg --version --quiet 2>&1', br'(\d+)\.(\d+)')
if not m: if not m:
return (0, 0) return (0, 0)
return (int(m.group(1)), int(m.group(2))) return (int(m.group(1)), int(m.group(2)))
_hgversion = None
def gethgversion():
global _hgversion
if _hgversion is None:
_hgversion = _gethgversion()
return _hgversion
@checkvers( @checkvers(
"hg", "Mercurial >= %s", list([(1.0 * x) / 10 for x in range(9, 99)]) "hg", "Mercurial >= %s", list([(1.0 * x) / 10 for x in range(9, 99)])
) )
def has_hg_range(v): def has_hg_range(v):
major, minor = v.split('.')[0:2] major, minor = v.split('.')[0:2]
return gethgversion() >= (int(major), int(minor)) return gethgversion() >= (int(major), int(minor))