| pulkit |
| hg-reviewers |
This is done by discarding any partial cache entry, instead of
filling the partial cache entry with 0xff before.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| Path | Packages | |||
|---|---|---|---|---|
| M | mercurial/tags.py (15 lines) | |||
| M | tests/test-tags.t (16 lines) |
| Status | Author | Revision | |
|---|---|---|---|
| Closed | valentin.gatienbaron | ||
| Closed | valentin.gatienbaron | ||
| Closed | valentin.gatienbaron |
| # file. This offset is also adjusted when new entries are calculated | # file. This offset is also adjusted when new entries are calculated | ||||
| # for array members. | # for array members. | ||||
| cllen = len(repo.changelog) | cllen = len(repo.changelog) | ||||
| wantedlen = cllen * _fnodesrecsize | wantedlen = cllen * _fnodesrecsize | ||||
| rawlen = len(self._raw) | rawlen = len(self._raw) | ||||
| self._dirtyoffset = None | self._dirtyoffset = None | ||||
| if rawlen < wantedlen: | rawlentokeep = min(wantedlen, (rawlen / _fnodesrecsize) * _fnodesrecsize) | ||||
| self._dirtyoffset = rawlen | if rawlen > rawlentokeep: | ||||
| self._raw.extend(b'\xff' * (wantedlen - rawlen)) | |||||
| elif rawlen > wantedlen: | |||||
| # There's no easy way to truncate array instances. This seems | # There's no easy way to truncate array instances. This seems | ||||
| # slightly less evil than copying a potentially large array slice. | # slightly less evil than copying a potentially large array slice. | ||||
| for i in range(rawlen - wantedlen): | for i in range(rawlen - rawlentokeep): | ||||
| self._raw.pop() | self._raw.pop() | ||||
| self._dirtyoffset = len(self._raw) | rawlen = len(self._raw) | ||||
| self._dirtyoffset = rawlen | |||||
| if rawlen < wantedlen: | |||||
| if self._dirtyoffset is None: | |||||
| self._dirtyoffset = rawlen | |||||
| self._raw.extend(b'\xff' * (wantedlen - rawlen)) | |||||
| def getfnode(self, node, computemissing=True): | def getfnode(self, node, computemissing=True): | ||||
| """Obtain the filenode of the .hgtags file at a specified revision. | """Obtain the filenode of the .hgtags file at a specified revision. | ||||
| If the value is in the cache, the entry will be validated and returned. | If the value is in the cache, the entry will be validated and returned. | ||||
| Otherwise, the filenode will be computed and returned unless | Otherwise, the filenode will be computed and returned unless | ||||
| "computemissing" is False, in which case None will be returned without | "computemissing" is False, in which case None will be returned without | ||||
| any potentially expensive computation being performed. | any potentially expensive computation being performed. | ||||
| $ hg blackbox -l 6 | $ hg blackbox -l 6 | ||||
| 1970/01/01 00:00:00 bob @8dbfe60eff306a54259cfe007db9e330e7ecf866 (5000)> tags | 1970/01/01 00:00:00 bob @8dbfe60eff306a54259cfe007db9e330e7ecf866 (5000)> tags | ||||
| 1970/01/01 00:00:00 bob @8dbfe60eff306a54259cfe007db9e330e7ecf866 (5000)> writing 24 bytes to cache/hgtagsfnodes1 | 1970/01/01 00:00:00 bob @8dbfe60eff306a54259cfe007db9e330e7ecf866 (5000)> writing 24 bytes to cache/hgtagsfnodes1 | ||||
| 1970/01/01 00:00:00 bob @8dbfe60eff306a54259cfe007db9e330e7ecf866 (5000)> 3/4 cache hits/lookups in * seconds (glob) | 1970/01/01 00:00:00 bob @8dbfe60eff306a54259cfe007db9e330e7ecf866 (5000)> 3/4 cache hits/lookups in * seconds (glob) | ||||
| 1970/01/01 00:00:00 bob @8dbfe60eff306a54259cfe007db9e330e7ecf866 (5000)> writing .hg/cache/tags2-visible with 1 tags | 1970/01/01 00:00:00 bob @8dbfe60eff306a54259cfe007db9e330e7ecf866 (5000)> writing .hg/cache/tags2-visible with 1 tags | ||||
| 1970/01/01 00:00:00 bob @8dbfe60eff306a54259cfe007db9e330e7ecf866 (5000)> tags exited 0 after * seconds (glob) | 1970/01/01 00:00:00 bob @8dbfe60eff306a54259cfe007db9e330e7ecf866 (5000)> tags exited 0 after * seconds (glob) | ||||
| 1970/01/01 00:00:00 bob @8dbfe60eff306a54259cfe007db9e330e7ecf866 (5000)> blackbox -l 6 | 1970/01/01 00:00:00 bob @8dbfe60eff306a54259cfe007db9e330e7ecf866 (5000)> blackbox -l 6 | ||||
| Junk data + missing cache entries results in hg further corrupting the | On junk data + missing cache entries, hg also overwrites the junk. | ||||
| cache, then failing. | |||||
| $ rm -f .hg/cache/tags2-visible | $ rm -f .hg/cache/tags2-visible | ||||
| $ truncate .hg/cache/hgtagsfnodes1 -s -10 | $ truncate .hg/cache/hgtagsfnodes1 -s -10 | ||||
| $ hg debugtagscache | tail -2 | $ hg debugtagscache | tail -2 | ||||
| 4 0c192d7d5e6b78a714de54a2e9627952a877e25a 0c04f2a8af31de17fab7422878ee5a2dadbc943d | 4 0c192d7d5e6b78a714de54a2e9627952a877e25a 0c04f2a8af31de17fab7422878ee5a2dadbc943d | ||||
| 5 8dbfe60eff306a54259cfe007db9e330e7ecf866 0c04f2a8af31de17fab7ffffffffffffffffffff | 5 8dbfe60eff306a54259cfe007db9e330e7ecf866 missing/invalid | ||||
| $ hg tags | $ hg tags | ||||
| abort: data/.hgtags.i@0c04f2a8af31: no match found! | tip 5:8dbfe60eff30 | ||||
| [255] | bar 1:78391a272241 | ||||
| $ hg debugtagscache | tail -2 | $ hg debugtagscache | tail -2 | ||||
| 4 0c192d7d5e6b78a714de54a2e9627952a877e25a 0c04f2a8af31de17fab7422878ee5a2dadbc943d | 4 0c192d7d5e6b78a714de54a2e9627952a877e25a 0c04f2a8af31de17fab7422878ee5a2dadbc943d | ||||
| 5 8dbfe60eff306a54259cfe007db9e330e7ecf866 0c04f2a8af31de17fab7ffffffffffffffffffff | 5 8dbfe60eff306a54259cfe007db9e330e7ecf866 0c04f2a8af31de17fab7422878ee5a2dadbc943d | ||||
| # fix up the cache | |||||
| $ rm .hg/cache/hgtagsfnodes1 | |||||
| $ hg tags -q | |||||
| tip | |||||
| bar | |||||
| #if unix-permissions no-root | #if unix-permissions no-root | ||||
| Errors writing to .hgtags fnodes cache are silently ignored | Errors writing to .hgtags fnodes cache are silently ignored | ||||
| $ echo dummy2 > foo | $ echo dummy2 > foo | ||||
| $ hg commit -m throwaway2 | $ hg commit -m throwaway2 | ||||
| $ chmod a-w .hg/cache/hgtagsfnodes1 | $ chmod a-w .hg/cache/hgtagsfnodes1 | ||||