Page MenuHomePhabricator

remotefilelog-test: glob some flacky output line (issue6083)
ClosedPublic

Authored by marmoute on Mon, Feb 10, 5:38 AM.

Details

Summary

The two following lines are flacky underload, yet the final result is correct.
The command involves background pre-check of output, these are not stable
probably because they run in parallel in multiple process.

I spent a couple of hours trying to understand the pattern and gave up. The
documented intend of these tests is safely guaranteed by checking the cache
content after the command.

If it become useful to start testing precise internal details of the, they will
have to be tested in a more appropriate framework than .t tests.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute created this revision.Mon, Feb 10, 5:38 AM
pulkit accepted this revision.Mon, Feb 10, 12:41 PM
This revision is now accepted and ready to land.Mon, Feb 10, 12:41 PM

Is this and next one targeted for stable branch? I see a mention about that in next patch.