( )⚙ D8108 tags: use modern // operator for division

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8108

tags: use modern // operator for division
ClosedPublic

Authored by durin42 on Feb 10 2020, 9:09 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG8ec186c1ccfe: tags: use modern // operator for division
Summary

Fixes a test on Python 3.

  1. skip-blame only correcting a division operator, not a substantive change

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Feb 10 2020, 9:09 PM
pulkit accepted this revision.Feb 10 2020, 9:13 PM
This revision is now accepted and ready to land.Feb 10 2020, 9:13 PM
durin42 added a commit: rHG8ec186c1ccfe: tags: use modern // operator for division.Feb 10 2020, 9:26 PM
Closed by commit rHG8ec186c1ccfe: tags: use modern // operator for division (authored by durin42). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/tags.py (2 lines)

Diff 20141

mercurial/tags.py

# for array members. # for array members.
cllen = len(repo.changelog) cllen = len(repo.changelog)
wantedlen = cllen * _fnodesrecsize wantedlen = cllen * _fnodesrecsize
rawlen = len(self._raw) rawlen = len(self._raw)
self._dirtyoffset = None self._dirtyoffset = None
rawlentokeep = min( rawlentokeep = min(
wantedlen, (rawlen / _fnodesrecsize) * _fnodesrecsize wantedlen, (rawlen // _fnodesrecsize) * _fnodesrecsize
) )
if rawlen > rawlentokeep: if rawlen > rawlentokeep:
# There's no easy way to truncate array instances. This seems # There's no easy way to truncate array instances. This seems
# slightly less evil than copying a potentially large array slice. # slightly less evil than copying a potentially large array slice.
for i in range(rawlen - rawlentokeep): for i in range(rawlen - rawlentokeep):
self._raw.pop() self._raw.pop()
rawlen = len(self._raw) rawlen = len(self._raw)
self._dirtyoffset = rawlen self._dirtyoffset = rawlen