Page MenuHomePhabricator

bookmarks: refactor in preparation for next commit

Authored by valentin.gatienbaron on Feb 13 2020, 11:32 PM.

Diff Detail

rHG Mercurial
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pulkit accepted this revision.Feb 21 2020, 4:14 AM
This revision is now accepted and ready to land.Feb 21 2020, 4:14 AM

Amended the following in flight to test-check-format.t happy:

diff --git a/mercurial/ b/mercurial/
--- a/mercurial/
+++ b/mercurial/
@@ -462,9 +462,11 @@ def update(repo, parents, node):
             marks.applychanges(repo, tr, bmchanges)
     return bool(bmchanges)
 def isdivergent(b):
     return b'@' in b and not b.endswith(b'@')
 def listbinbookmarks(repo):
     # We may try to list bookmarks on a repo type that does not
     # support it (e.g., statichttprepository).

Sorry, I had tried installing black, but it was not the right version. After looking some more, pip3 install black is what was needed I think.