This is an archive of the discontinued Mercurial Phabricator instance.

phabricator: fix a phabsend crash when processing a renamed binary
ClosedPublic

Authored by mharbison72 on Feb 18 2020, 3:59 PM.

Details

Summary

This was a trivial fix, and some more tests are added to cover binary files.
Since the old filecontext is passed in, the old name is still available. But I
noticed some weirdness around what it marked as binary and not, and what is
viewable in Phabricator. Those things have been flagged, and will probably take
some digging.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Feb 18 2020, 3:59 PM
pulkit accepted this revision.Feb 21 2020, 3:55 AM
This revision is now accepted and ready to land.Feb 21 2020, 3:55 AM

Converted line endings to unix one in flight.