This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8149

drawdag: abide by new createmarkers() API
ClosedPublic

Authored by martinvonz on Feb 25 2020, 3:53 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHGdda2341d6664: drawdag: abide by new createmarkers() API
Summary

The obsolete.createmarkers() API was changed in 6335c0de80fa
(obsolete: allow multiple predecessors in createmarkers, 2018-09-22)
to prefer its precursors input to be a tuple instead of a single
precursor. Let's fix drawdag.py to comply.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

martinvonz created this revision.Feb 25 2020, 3:53 PM
pulkit accepted this revision.Feb 26 2020, 4:37 AM
This revision is now accepted and ready to land.Feb 26 2020, 4:37 AM
martinvonz added a commit: rHGdda2341d6664: drawdag: abide by new createmarkers() API.Feb 26 2020, 5:51 AM
Closed by commit rHGdda2341d6664: drawdag: abide by new createmarkers() API (authored by martinvonz). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/drawdag.py (6 lines)

Diff 20301

tests/drawdag.py

continue continue
cmd = args[0].strip() cmd = args[0].strip()
arg = args[1].strip() arg = args[1].strip()
if cmd in (b'replace', b'rebase', b'amend'): if cmd in (b'replace', b'rebase', b'amend'):
nodes = [getctx(m) for m in arg.split(b'->')] nodes = [getctx(m) for m in arg.split(b'->')]
for i in range(len(nodes) - 1): for i in range(len(nodes) - 1):
rels.append((nodes[i], (nodes[i + 1],))) rels.append(((nodes[i],), (nodes[i + 1],)))
elif cmd in (b'split',): elif cmd in (b'split',):
pre, succs = arg.split(b'->') pre, succs = arg.split(b'->')
succs = succs.split(b',') succs = succs.split(b',')
rels.append((getctx(pre), (getctx(s) for s in succs))) rels.append(((getctx(pre),), (getctx(s) for s in succs)))
elif cmd in (b'prune',): elif cmd in (b'prune',):
for n in arg.split(b','): for n in arg.split(b','):
rels.append((getctx(n), ())) rels.append(((getctx(n),), ()))
if rels: if rels:
obsolete.createmarkers(repo, rels, date=(0, 0), operation=cmd) obsolete.createmarkers(repo, rels, date=(0, 0), operation=cmd)