This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8177

hgit: fix some issues spotted by pylint integration with editor
AbandonedPublic

Authored by durin42 on Feb 28 2020, 8:19 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

pulkit created this revision.Feb 28 2020, 8:19 AM
pulkit retitled this revision from hgit: fix self.gitrepo -> self._git_repo to hgit: fix some issues spotted by pylint integration with editor.Feb 28 2020, 8:48 AM
pulkit updated this revision to Diff 20374.
durin42 added a reviewer: pulkit.Mar 3 2020, 1:50 PM
durin42 commandeered this revision.
durin42 added a subscriber: durin42.

Folded this into the base revision, many thanks.

durin42 abandoned this revision.Mar 3 2020, 1:50 PM

Revision Contents
Changeset List

PathPackages
Mhgext/git/manifest.py (2 lines)

Diff 20372

hgext/git/manifest.py

val = self._pending_changes[path] val = self._pending_changes[path]
if val is None: if val is None:
raise KeyError raise KeyError
return val return val
t = self._tree t = self._tree
comps = upath.split('/') comps = upath.split('/')
for comp in comps[:-1]: for comp in comps[:-1]:
te = self._tree[comp] te = self._tree[comp]
t = self.gitrepo[te.id] t = self._git_repo[te.id]
ent = t[comps[-1]] ent = t[comps[-1]]
if ent.filemode == pygit2.GIT_FILEMODE_BLOB: if ent.filemode == pygit2.GIT_FILEMODE_BLOB:
flags = b'' flags = b''
elif ent.filemode == pygit2.GIT_FILEMODE_BLOB_EXECUTABLE: elif ent.filemode == pygit2.GIT_FILEMODE_BLOB_EXECUTABLE:
flags = b'x' flags = b'x'
elif ent.filemode == pygit2.GIT_FILEMODE_LINK: elif ent.filemode == pygit2.GIT_FILEMODE_LINK:
flags = b'l' flags = b'l'
else: else: