Page MenuHomePhabricator

phabricator: avoid a stacktrace when command arguments are missing
ClosedPublic

Authored by mharbison72 on Mar 4 2020, 12:58 AM.

Details

Summary

Previously, the TypeError wasn't properly converted to a SignatureError when
improper arguments were supplied to the inner function, because the stack depth
is 2 inside the vcrcommand decorator. The __name__ and __doc__ attributes
need to be reassigned to the new wrapper so that the help summary is available.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mharbison72 created this revision.Mar 4 2020, 12:58 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.