This is an archive of the discontinued Mercurial Phabricator instance.

Status	Author	Revision
Closed	mharbison72	D8221 phabricator: also check parent fctx for binary where it is checked for UTF-8
Closed	mharbison72	D8220 phabricator: don't infer the old `fctx` in `notutf8()`
Closed	mharbison72	D8219 phabricator: rename a variable to clarify that it is the parent filecontext
Closed	mharbison72	D8218 phabricator: pass old `fctx` to `addoldbinary()` instead of inferring it

Diff 20481


	def addremoved(pdiff, ctx, removed):			def addremoved(pdiff, ctx, removed):
	"""add removed files to the phabdiff. Shouldn't include moves"""			"""add removed files to the phabdiff. Shouldn't include moves"""
	for fname in removed:			for fname in removed:
	pchange = phabchange(			pchange = phabchange(
	currentPath=fname, oldPath=fname, type=DiffChangeType.DELETE			currentPath=fname, oldPath=fname, type=DiffChangeType.DELETE
	)			)
	pchange.addoldmode(gitmode[ctx.p1()[fname].flags()])			pchange.addoldmode(gitmode[ctx.p1()[fname].flags()])
	fctx = ctx.p1()[fname]			oldfctx = ctx.p1()[fname]
	if not (fctx.isbinary() or notutf8(fctx)):			if not (oldfctx.isbinary() or notutf8(oldfctx)):
	maketext(pchange, ctx, fname)			maketext(pchange, ctx, fname)

	pdiff.addchange(pchange)			pdiff.addchange(pchange)


	def addmodified(pdiff, ctx, modified):			def addmodified(pdiff, ctx, modified):
	"""add modified files to the phabdiff"""			"""add modified files to the phabdiff"""
	for fname in modified:			for fname in modified: