This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8225

rust-cpython: add `debug` module to expose debug information to Python
ClosedPublic

Authored by Alphare on Mar 5 2020, 4:26 AM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Commits
rHGd4f19eb471ca: rust-cpython: add `debug` module to expose debug information to Python
Summary

This will be mostly used in debuginstall.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Mar 5 2020, 4:26 AM
Alphare added a comment.Mar 6 2020, 8:46 AM

Note to reviewers: I will be rebasing this when D8248 is merged and adding a version number to this debug module, so don't take it yet.

Alphare added a commit: rHGd4f19eb471ca: rust-cpython: add `debug` module to expose debug information to Python.Mar 11 2020, 12:24 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHGd4f19eb471ca: rust-cpython: add `debug` module to expose debug information to Python (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
AMrust/hg-cpython/src/debug.rs (26 lines)
Mrust/hg-cpython/src/lib.rs (2 lines)

Diff 20724

rust/hg-cpython/src/debug.rs

  • This file was added.
// debug.rs
//
// Copyright 2020 Raphaël Gomès <rgomes@octobus.net>
//
// This software may be used and distributed according to the terms of the
// GNU General Public License version 2 or any later version.
//! Module to get debug information about Rust extensions.
use cpython::{PyDict, PyModule, PyResult, Python};
/// Create the module, with `__package__` given from parent
pub fn init_module(py: Python, package: &str) -> PyResult<PyModule> {
let dotted_name = &format!("{}.debug", package);
let m = PyModule::new(py, dotted_name)?;
m.add(py, "__package__", package)?;
m.add(py, "__doc__", "Rust debugging information")?;
m.add(py, "re2_installed", cfg!(feature = "with-re2"))?;
let sys = PyModule::import(py, "sys")?;
let sys_modules: PyDict = sys.get(py, "modules")?.extract(py)?;
sys_modules.set_item(py, dotted_name, &m)?;
Ok(m)
}

rust/hg-cpython/src/lib.rs

extern crate cpython; extern crate cpython;
pub mod ancestors; pub mod ancestors;
mod cindex; mod cindex;
mod conversion; mod conversion;
#[macro_use] #[macro_use]
pub mod ref_sharing; pub mod ref_sharing;
pub mod dagops; pub mod dagops;
pub mod debug;
pub mod dirstate; pub mod dirstate;
pub mod discovery; pub mod discovery;
pub mod exceptions; pub mod exceptions;
pub mod parsers; pub mod parsers;
pub mod revlog; pub mod revlog;
pub mod utils; pub mod utils;
py_module_initializer!(rustext, initrustext, PyInit_rustext, |py, m| { py_module_initializer!(rustext, initrustext, PyInit_rustext, |py, m| {
m.add( m.add(
py, py,
"__doc__", "__doc__",
"Mercurial core concepts - Rust implementation", "Mercurial core concepts - Rust implementation",
)?; )?;
let dotted_name: String = m.get(py, "__name__")?.extract(py)?; let dotted_name: String = m.get(py, "__name__")?.extract(py)?;
m.add(py, "ancestor", ancestors::init_module(py, &dotted_name)?)?; m.add(py, "ancestor", ancestors::init_module(py, &dotted_name)?)?;
m.add(py, "dagop", dagops::init_module(py, &dotted_name)?)?; m.add(py, "dagop", dagops::init_module(py, &dotted_name)?)?;
m.add(py, "debug", debug::init_module(py, &dotted_name)?)?;
m.add(py, "discovery", discovery::init_module(py, &dotted_name)?)?; m.add(py, "discovery", discovery::init_module(py, &dotted_name)?)?;
m.add(py, "dirstate", dirstate::init_module(py, &dotted_name)?)?; m.add(py, "dirstate", dirstate::init_module(py, &dotted_name)?)?;
m.add(py, "revlog", revlog::init_module(py, &dotted_name)?)?; m.add(py, "revlog", revlog::init_module(py, &dotted_name)?)?;
m.add( m.add(
py, py,
"parsers", "parsers",
parsers::init_parsers_module(py, &dotted_name)?, parsers::init_parsers_module(py, &dotted_name)?,
)?; )?;