Page MenuHomePhabricator

rust-status: refactor options into a `StatusOptions` struct
Needs ReviewPublic

Authored by Alphare on Thu, Feb 6, 10:15 AM.

Details

Reviewers
marmoute
Group Reviewers
hg-reviewers

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

Alphare created this revision.Thu, Feb 6, 10:15 AM
kevincox added inline comments.Mon, Feb 10, 10:56 AM
rust/hg-core/src/dirstate/status.rs
208

These names aren't very meaningful to me but maybe that is because I'm not super familiar with the domain.

Alphare added inline comments.Mon, Feb 10, 11:22 AM
rust/hg-core/src/dirstate/status.rs
208

It doesn't hurt to have some documentation. They're not super obvious indeed.

Alphare updated this revision to Diff 20044.Mon, Feb 10, 11:30 AM
Alphare updated this revision to Diff 20155.Tue, Feb 11, 5:55 AM
Alphare updated this revision to Diff 20164.Tue, Feb 11, 6:13 AM
Alphare updated this revision to Diff 20184.Thu, Feb 13, 12:37 PM
marmoute accepted this revision.Fri, Feb 14, 3:44 AM
marmoute added a subscriber: marmoute.

looks good to me. thanks for plitting