Page MenuHomePhabricator

copies-tests: add a test with a rename overwriting another file
ClosedPublic

Authored by marmoute on Mar 5 2020, 1:14 PM.

Details

Summary

This is a variation of the "BD" case, but this time, the file is not "new", it
is overwritten by another file being renamed.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Mar 5 2020, 1:14 PM
marmoute updated this revision to Diff 20547.Mar 6 2020, 5:21 AM
martinvonz added inline comments.
tests/test-copies-chain-merge.t
298–299

unrelated to this patch, but maybe we can also remove this final summary? i've never looked at it while reviewing theses patches and i don't feel like i've missed anything as a result.

Yes, it

tests/test-copies-chain-merge.t
298–299

Yes, it was more useful at the begining, when less branch were involved?

martinvonz added inline comments.Mar 6 2020, 12:30 PM
tests/test-copies-chain-merge.t
298–299

Okay, want to send a patch removing it then? Ideally that patch would come early in the series so the other patches (like this one) would get simpler.

marmoute added inline comments.Mar 6 2020, 5:55 PM
tests/test-copies-chain-merge.t
298–299

Yes, my previous message implied I would do so in the next iteration.

[grmlm, comment not sent]

marmoute updated this revision to Diff 20592.Mar 6 2020, 6:51 PM

series update after Martin feedback

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.