This is an archive of the discontinued Mercurial Phabricator instance.

copies-tests: swap two branch description
ClosedPublic

Authored by marmoute on Mar 6 2020, 5:20 AM.

Details

Summary

They were swapped and now match their intended block.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

marmoute created this revision.Mar 6 2020, 5:20 AM
martinvonz added inline comments.
tests/test-copies-chain-merge.t
42

nit: lower-case "having" :P

marmoute added inline comments.Mar 6 2020, 11:07 AM
tests/test-copies-chain-merge.t
42

can you fix this inflight?

martinvonz added inline comments.Mar 6 2020, 11:15 AM
tests/test-copies-chain-merge.t
42

Unless I have other comments on the series, sure. I'm not done reviewing yet.

marmoute added inline comments.Mar 6 2020, 11:20 AM
tests/test-copies-chain-merge.t
42

This is the first patch of the series, so I don't expect anything to block it ;-)

martinvonz added inline comments.Mar 6 2020, 11:26 AM
tests/test-copies-chain-merge.t
42

Sure, but if I have comments on other patches in the series, it seems fair that you address this one as well instead of leaving that to the reviewer.

marmoute marked 2 inline comments as done.Mar 6 2020, 5:38 PM

done locally. pull update the diff when done

marmoute retitled this revision from test-copies: swap two branch description to copies-tests: swap two branch description.Mar 6 2020, 6:51 PM
marmoute updated this revision to Diff 20587.

series update after Martin feedback

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.