( )⚙ D8267 hghave: add a check for pygit2

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8267

hghave: add a check for pygit2
ClosedPublic

Authored by martinvonz on Mar 9 2020, 5:18 PM.

Details

Reviewers
mharbison72
Group Reviewers
hg-reviewers
Commits
rHG2e464925f662: hghave: add a check for pygit2
Summary

This will make it easy to use availability of pygit2 as in conditions
such as #if pygit2 and (pygit2 !). It also makes it a little
clearer why the test case skipped (when that happens).

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

martinvonz created this revision.Mar 9 2020, 5:18 PM
mharbison72 accepted this revision.Mar 9 2020, 6:30 PM
martinvonz added a commit: rHG2e464925f662: hghave: add a check for pygit2.Mar 9 2020, 6:46 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG2e464925f662: hghave: add a check for pygit2 (authored by martinvonz). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mtests/hghave.py (11 lines)
Mtests/test-git-interop.t (3 lines)

Diff 20644

tests/hghave.py

def getgitversion(): def getgitversion():
m = matchoutput('git --version 2>&1', br'git version (\d+)\.(\d+)') m = matchoutput('git --version 2>&1', br'git version (\d+)\.(\d+)')
if not m: if not m:
return (0, 0) return (0, 0)
return (int(m.group(1)), int(m.group(2))) return (int(m.group(1)), int(m.group(2)))
@check("pygit2", "pygit2 Python library")
def has_git():
try:
import pygit2
pygit2.Oid # silence unused import
return True
except ImportError:
return False
# https://github.com/git-lfs/lfs-test-server # https://github.com/git-lfs/lfs-test-server
@check("lfs-test-server", "git-lfs test server") @check("lfs-test-server", "git-lfs test server")
def has_lfsserver(): def has_lfsserver():
exe = 'lfs-test-server' exe = 'lfs-test-server'
if has_windows(): if has_windows():
exe = 'lfs-test-server.exe' exe = 'lfs-test-server.exe'
return any( return any(
os.access(os.path.join(path, exe), os.X_OK) os.access(os.path.join(path, exe), os.X_OK)

tests/test-git-interop.t

This test requires pygit2: #require pygit2
> $PYTHON -c 'import pygit2' || exit 80
Setup: Setup:
> GIT_AUTHOR_NAME='test'; export GIT_AUTHOR_NAME > GIT_AUTHOR_NAME='test'; export GIT_AUTHOR_NAME
> GIT_AUTHOR_EMAIL='test@example.org'; export GIT_AUTHOR_EMAIL > GIT_AUTHOR_EMAIL='test@example.org'; export GIT_AUTHOR_EMAIL
> GIT_AUTHOR_DATE="2007-01-01 00:00:00 +0000"; export GIT_AUTHOR_DATE > GIT_AUTHOR_DATE="2007-01-01 00:00:00 +0000"; export GIT_AUTHOR_DATE
> GIT_COMMITTER_NAME="$GIT_AUTHOR_NAME"; export GIT_COMMITTER_NAME > GIT_COMMITTER_NAME="$GIT_AUTHOR_NAME"; export GIT_COMMITTER_NAME
> GIT_COMMITTER_EMAIL="$GIT_AUTHOR_EMAIL"; export GIT_COMMITTER_EMAIL > GIT_COMMITTER_EMAIL="$GIT_AUTHOR_EMAIL"; export GIT_COMMITTER_EMAIL
> GIT_COMMITTER_DATE="$GIT_AUTHOR_DATE"; export GIT_COMMITTER_DATE > GIT_COMMITTER_DATE="$GIT_AUTHOR_DATE"; export GIT_COMMITTER_DATE