Page MenuHomePhabricator

archive: fix crash when archiving to gzip file with Python 3.8.2+
AbandonedPublic

Authored by durin42 on Mar 10 2020, 4:21 PM.

Details

Reviewers
ludovicchabant
Group Reviewers
hg-reviewers

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

ludovicchabant created this revision.Mar 10 2020, 4:21 PM
ludovicchabant added a comment.EditedMar 10 2020, 4:22 PM

The _write_gzip_header function is now getting passed the compression level in the latest Python release.

It does seem brittle to me to override some Python internal method anyway? Can we get rid of this altogether?

marmoute added a subscriber: marmoute.EditedMar 10 2020, 9:42 PM

The _write_gzip_header function is now getting passed the compression level in the latest Python release.
It does seem brittle to me to override some Python internal method anyway? Can we get rid of this altogether?

https://www.mercurial-scm.org/repo/hg-committed/rev/b7ca03dff14c

(to clarify, a fix for issue6284 landed on stable. You can drop this patch)

durin42 commandeered this revision.
durin42 abandoned this revision.