This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8299

remotefilelog: add fake heads() method that allows viewing a file in hgweb
ClosedPublic

Authored by durin42 on Mar 17 2020, 5:44 PM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG9e63108123a4: remotefilelog: add fake heads() method that allows viewing a file in hgweb
Summary

As best I can discern, this is not going to hurt anything, but it'll
cause a couple of options to exist in the UI that are
nonsensical. That seems fine, given the nature of remotefilelog.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

durin42 created this revision.Mar 17 2020, 5:44 PM
pulkit accepted this revision.Mar 19 2020, 4:04 AM
This revision is now accepted and ready to land.Mar 19 2020, 4:04 AM

Revision Contents
Changeset List

Diff 20830

hgext/remotefilelog/remotefilelog.py

# The length of .hgtags is used to fast path tag checking. # The length of .hgtags is used to fast path tag checking.
# remotefilelog doesn't support .hgtags since the entire .hgtags # remotefilelog doesn't support .hgtags since the entire .hgtags
# history is needed. Use the excludepattern setting to make # history is needed. Use the excludepattern setting to make
# .hgtags a normal filelog. # .hgtags a normal filelog.
return 0 return 0
raise RuntimeError(b"len not supported") raise RuntimeError(b"len not supported")
def heads(self):
# Fake heads of the filelog to satisfy hgweb.
return []
def empty(self): def empty(self):
return False return False
def flags(self, node): def flags(self, node):
if isinstance(node, int): if isinstance(node, int):
raise error.ProgrammingError( raise error.ProgrammingError(
b'remotefilelog does not accept integer rev for flags' b'remotefilelog does not accept integer rev for flags'
) )

tests/test-remotefilelog-hgweb.t

$ cd .. $ cd ..
$ hgcloneshallow ssh://user@dummy/master wdir --noupdate -q $ hgcloneshallow ssh://user@dummy/master wdir --noupdate -q
$ cd wdir $ cd wdir
$ hg serve -n test -p $HGPORT -d --pid-file=hg.pid -E errors.log $ hg serve -n test -p $HGPORT -d --pid-file=hg.pid -E errors.log
$ cat hg.pid >> $DAEMON_PIDS $ cat hg.pid >> $DAEMON_PIDS
$ (get-with-headers.py localhost:$HGPORT 'file/tip/x') $ get-with-headers.py localhost:$HGPORT 'file/tip/x' | head -n 10
500 Internal Server Error 200 Script output follows
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en-US">
<head>
<link rel="icon" href="/static/hgicon.png" type="image/png" />
<meta name="robots" content="index, nofollow" />
<link rel="stylesheet" href="/static/style-paper.css" type="text/css" />
<script type="text/javascript" src="/static/mercurial.js"></script>
Internal Server Error (no-eol)
[1]