This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8300

rust-status: add trace-level logging for Rust status fallback for debugging
ClosedPublic

Authored by Alphare on Mar 18 2020, 10:01 AM.

Details

Reviewers
pulkit
Group Reviewers
hg-reviewers
Commits
rHG245aec57d76a: rust-status: add trace-level logging for Rust status fallback for debugging
Summary

The added log crate is already a sub-dependency.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.Mar 18 2020, 10:01 AM
pulkit accepted this revision.Mar 19 2020, 4:07 AM
This revision is now accepted and ready to land.Mar 19 2020, 4:07 AM

Revision Contents
Changeset List

Diff 20832

rust/Cargo.lock

[[package]] [[package]]
name = "hg-cpython" name = "hg-cpython"
version = "0.1.0" version = "0.1.0"
dependencies = [ dependencies = [
"cpython 0.4.1 (registry+https://github.com/rust-lang/crates.io-index)", "cpython 0.4.1 (registry+https://github.com/rust-lang/crates.io-index)",
"hg-core 0.1.0", "hg-core 0.1.0",
"libc 0.2.67 (registry+https://github.com/rust-lang/crates.io-index)", "libc 0.2.67 (registry+https://github.com/rust-lang/crates.io-index)",
"log 0.4.8 (registry+https://github.com/rust-lang/crates.io-index)",
"simple_logger 1.6.0 (registry+https://github.com/rust-lang/crates.io-index)", "simple_logger 1.6.0 (registry+https://github.com/rust-lang/crates.io-index)",
] ]
[[package]] [[package]]
name = "lazy_static" name = "lazy_static"
version = "1.4.0" version = "1.4.0"
source = "registry+https://github.com/rust-lang/crates.io-index" source = "registry+https://github.com/rust-lang/crates.io-index"

rust/hg-cpython/Cargo.toml

# Enable one of these features to build a test executable linked to libpython: # Enable one of these features to build a test executable linked to libpython:
# e.g. cargo test --no-default-features --features python27-bin # e.g. cargo test --no-default-features --features python27-bin
python27-bin = ["cpython/python27-sys"] python27-bin = ["cpython/python27-sys"]
python3-bin = ["cpython/python3-sys"] python3-bin = ["cpython/python3-sys"]
[dependencies] [dependencies]
hg-core = { path = "../hg-core"} hg-core = { path = "../hg-core"}
libc = '*' libc = '*'
log = "0.4.8"
simple_logger = "1.6.0" simple_logger = "1.6.0"
[dependencies.cpython] [dependencies.cpython]
version = "0.4" version = "0.4"
default-features = false default-features = false

rust/hg-cpython/src/dirstate/status.rs

} }
Ok(list) Ok(list)
} }
fn handle_fallback(py: Python, err: StatusError) -> PyErr { fn handle_fallback(py: Python, err: StatusError) -> PyErr {
match err { match err {
StatusError::Pattern(e) => { StatusError::Pattern(e) => {
PyErr::new::<FallbackError, _>(py, e.to_string()) let as_string = e.to_string();
log::trace!("Rust status fallback: `{}`", &as_string);
PyErr::new::<FallbackError, _>(py, &as_string)
} }
e => PyErr::new::<ValueError, _>(py, e.to_string()), e => PyErr::new::<ValueError, _>(py, e.to_string()),
} }
} }
pub fn status_wrapper( pub fn status_wrapper(
py: Python, py: Python,
dmap: DirstateMap, dmap: DirstateMap,