Page MenuHomePhabricator

cext: move more variable declarations to the top of the block for C89 support
AbandonedPublic

Authored by mharbison72 on Wed, Mar 25, 4:33 PM.

Details

Reviewers
None
Group Reviewers
hg-reviewers
Summary

These instances aren't compiled on Windows, so they don't matter much. But they
do get flagged by -Werror=declaration-after-statement in the next patch.

setup: build C extensions with -Werror=declaration-after-statement

MSVC 2008 still needs declarations at the top of the scope. I added it to the
3rd party code too in case somebody vendors a new version with a problem-
they'll get an early warning. Clang seems to ignore this (at least on 10.14
with Xcode 10), and gcc 7.4 will error out as desired on Ubuntu 18.04. Thanks
to Yuya for remembering the name of the option.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mharbison72 created this revision.Wed, Mar 25, 4:33 PM
mharbison72 abandoned this revision.Wed, Mar 25, 4:36 PM

This was a test run of phabsend --fold to show what the UI looks like. It's a fold of D8317 and D8318 (with the URLs removed).