Page MenuHomePhabricator

setup: build C extensions with -Werror=declaration-after-statement
ClosedPublic

Authored by mharbison72 on Fri, Mar 20, 11:55 PM.

Details

Summary

MSVC 2008 still needs declarations at the top of the scope. I added it to the
3rd party code too in case somebody vendors a new version with a problem-
they'll get an early warning. Clang seems to ignore this (at least on 10.14
with Xcode 10), and gcc 7.4 will error out as desired on Ubuntu 18.04. Thanks
to Yuya for remembering the name of the option.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Fri, Mar 20, 11:55 PM
marmoute accepted this revision.Sat, Mar 21, 12:02 AM
yuja added a subscriber: yuja.Sat, Mar 21, 12:55 AM
MSVC 2008 still needs declarations at the top of the scope.

Can you copy this to the code so we can recall why we enable this weird
warning option?

+if os.name != 'nt':
+ common_cflags = ['-Werror=declaration-after-statement']

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.