Page MenuHomePhabricator

phabricator: add basectx arguments to file related `phabsend` utilities
ClosedPublic

Authored by mharbison72 on Fri, Mar 20, 5:23 PM.

Details

Summary

This is in support of a future --fold option, that allows rolling up several
commits into a single review with a diff from the start to the end of the range.

There are no functional changes yet- the original ctx is also passed as the
new basectx, which represents the first commit in the review range (similar to
qbase in MQ parlance). Other functions will need the range of commits, but
these deal with status or the diffs, so they only need the end points.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mharbison72 created this revision.Fri, Mar 20, 5:23 PM
Alphare accepted this revision.Wed, Mar 25, 2:03 PM
Alphare added a subscriber: Alphare.

I am very curious as to how the UI will look on a folded series.

I am very curious as to how the UI will look on a folded series.

Thanks for the reviews!

See D8330. It basically looks the same, other than the Commits tab has multiple revisions.

pulkit accepted this revision.Thu, Mar 26, 4:50 AM
This revision is now accepted and ready to land.Thu, Mar 26, 4:50 AM