Page MenuHomePhabricator

py3: make setup.py's hgcommand() consistently return bytes
ClosedPublic

Authored by martinvonz on Mar 25 2020, 9:28 PM.

Details

Summary

Before this patch, it returned unicode when the command failed. That
made e.g. make local PYTHON=python3 fail on an obsolete commit.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

martinvonz created this revision.Mar 25 2020, 9:28 PM
mharbison72 accepted this revision.Mar 25 2020, 11:47 PM
pulkit accepted this revision.Mar 26 2020, 4:43 AM
This revision is now accepted and ready to land.Mar 26 2020, 4:43 AM