Page MenuHomePhabricator

tests: use `f --hexdump` to print file content
ClosedPublic

Authored by indygreg on Mar 28 2020, 9:40 PM.

Details

Summary

The inline print.py in this test wasn't fully compatible with
Python 3 because it was reading from sys.stdin, which already
normalized line endings since it operates in the realm of str on
Python 3. To do this correctly, we'd need to read from
sys.stdin.buffer on Python 3. This would entail conditional code.
I felt this was too much effort. So I just replaced the custom
script with f, which already knows how to do the right thing.

test-mactext.t now passes on Python 3 on Windows.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 28 2020, 9:40 PM
marmoute accepted this revision.Apr 1 2020, 4:18 AM
marmoute added a subscriber: marmoute.

sure

This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.