Page MenuHomePhabricator

tests: perform grep manually in test-doctest.py
ClosedPublic

Authored by indygreg on Mar 29 2020, 9:30 PM.

Details

Summary

This test has been failing on Windows since 0af56d3ee24c
introduced the hg files invocation. Specifically, Windows seems
to be choking on special characters in the fileset pattern. I
believe at least \n and > were causing issues.

I attempted various incantations to make the Windows command line
parser accept the fileset but couldn't get anything working.
I declared bankruptcy and just reimplemented the grepping code
in Python.

After this change, the test now passes on Windows again.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

indygreg created this revision.Mar 29 2020, 9:30 PM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.