This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8346

tests: force newlines to LF in tinyproxy.py
Needs RevisionPublic

Authored by indygreg on Mar 29 2020, 9:30 PM.

Details

Reviewers
marmoute
baymax
Group Reviewers
hg-reviewers
Summary

Yet another instance where we need to replace the sys.std* streams
to prevent CRLF from creeping in on Windows.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

indygreg created this revision.Mar 29 2020, 9:30 PM
marmoute accepted this revision.Apr 17 2020, 2:31 PM
marmoute added a subscriber: marmoute.

looks legit

marmoute added a subscriber: mharbison72.Apr 17 2020, 2:34 PM
marmoute resigned from this revision.

actually @mharbison72 comment on D8345 make me reconsider. Please allign the status of this with the status of D8345.

marmoute accepted this revision.Apr 17 2020, 4:01 PM
baymax requested changes to this revision.Jul 31 2020, 1:56 PM

There seems to have been no activities on this Diff for the past 3 Months.

By policy, we are automatically moving it out of the need-review state.

Please, move it back to need-review without hesitation if this diff should still be discussed.

:baymax:need-review-idle:

This revision now requires changes to proceed.Jul 31 2020, 1:56 PM

Revision Contents
Changeset List

PathPackages
Mtests/tinyproxy.py (18 lines)

Diff 20919

tests/tinyproxy.py

#!/usr/bin/env python #!/usr/bin/env python
from __future__ import absolute_import, print_function from __future__ import absolute_import, print_function
__doc__ = """Tiny HTTP Proxy. __doc__ = """Tiny HTTP Proxy.
This module implements GET, HEAD, POST, PUT and DELETE methods This module implements GET, HEAD, POST, PUT and DELETE methods
on BaseHTTPServer, and behaves as an HTTP proxy. The CONNECT on BaseHTTPServer, and behaves as an HTTP proxy. The CONNECT
method is also implemented experimentally, but has not been method is also implemented experimentally, but has not been
tested yet. tested yet.
Any help will be greatly appreciated. SUZUKI Hisao Any help will be greatly appreciated. SUZUKI Hisao
""" """
__version__ = "0.2.1" __version__ = "0.2.1"
import io
import optparse import optparse
import os import os
import select import select
import socket import socket
import sys import sys
from mercurial import ( from mercurial import (
pycompat, pycompat,
util, util,
) )
# Ensure Windows doesn't emit CRLF.
if sys.version_info[0] >= 3:
sys.stdout = io.TextIOWrapper(
sys.stdout.buffer,
sys.stdout.encoding,
sys.stdout.errors,
newline="\n",
line_buffering=sys.stdout.line_buffering,
)
sys.stderr = io.TextIOWrapper(
sys.stderr.buffer,
sys.stderr.encoding,
sys.stderr.errors,
newline="\n",
line_buffering=sys.stderr.line_buffering,
)
httpserver = util.httpserver httpserver = util.httpserver
socketserver = util.socketserver socketserver = util.socketserver
urlreq = util.urlreq urlreq = util.urlreq
if os.environ.get('HGIPV6', '0') == '1': if os.environ.get('HGIPV6', '0') == '1':
family = socket.AF_INET6 family = socket.AF_INET6
else: else:
family = socket.AF_INET family = socket.AF_INET