Page MenuHomePhabricator

remotefilelog: move fastlog logging inside _linknodeviafastlog
ClosedPublic

Authored by stash on Sep 28 2017, 12:49 PM.

Details

Summary

The goal of the whole series is to have logging around linknode fixup. It's a slow operation, and we have two heuristics to make it faster. Unfortunately we have no idea about how well these heuristics actually help. This series of diffs aims to fix this problem. After this series is landed and logging is enabled, I hope that we can find out if we really these heuristics at all.

Let's store all the fastlog logging inside fastlog function. This refactoring helps in the next diffs

Test Plan

Run test-remotefilelog-linknodes.t

Diff Detail

Repository
rFBHGX Facebook Mercurial Extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

stash created this revision.Sep 28 2017, 12:49 PM
stash edited the summary of this revision. (Show Details)Sep 28 2017, 1:09 PM
quark accepted this revision.Sep 29 2017, 8:47 PM
This revision is now accepted and ready to land.Sep 29 2017, 8:47 PM
quark added a comment.Sep 29 2017, 8:48 PM

Maybe it's more consistent if we just remove all i18n _ calls.

This revision was automatically updated to reflect the committed changes.