| Alphare |
| hg-reviewers |
It's checked at Locator::connect() since we'll have to do more stuff in
this function.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| use std::path::{Path, PathBuf}; | use std::path::{Path, PathBuf}; | ||||
| use std::process::{self, Command}; | use std::process::{self, Command}; | ||||
| use std::time::Duration; | use std::time::Duration; | ||||
| use tokio::prelude::*; | use tokio::prelude::*; | ||||
| use tokio_hglib::UnixClient; | use tokio_hglib::UnixClient; | ||||
| use tokio_process::{Child, CommandExt}; | use tokio_process::{Child, CommandExt}; | ||||
| use tokio_timer; | use tokio_timer; | ||||
| use super::message::ServerSpec; | |||||
| use super::procutil; | use super::procutil; | ||||
| const REQUIRED_SERVER_CAPABILITIES: &[&str] = &["attachio", "chdir", "runcommand"]; | |||||
| /// Helper to connect to and spawn a server process. | /// Helper to connect to and spawn a server process. | ||||
| #[derive(Clone, Debug)] | #[derive(Clone, Debug)] | ||||
| pub struct Locator { | pub struct Locator { | ||||
| hg_command: OsString, | hg_command: OsString, | ||||
| current_dir: PathBuf, | current_dir: PathBuf, | ||||
| env_vars: Vec<(OsString, OsString)>, | env_vars: Vec<(OsString, OsString)>, | ||||
| process_id: u32, | process_id: u32, | ||||
| base_sock_path: PathBuf, | base_sock_path: PathBuf, | ||||
| /// The server process will be spawned if not running. | /// The server process will be spawned if not running. | ||||
| pub fn connect(self) -> impl Future<Item = (Self, UnixClient), Error = io::Error> { | pub fn connect(self) -> impl Future<Item = (Self, UnixClient), Error = io::Error> { | ||||
| self.try_connect() | self.try_connect() | ||||
| } | } | ||||
| /// Tries to connect to the existing server, or spawns new if not running. | /// Tries to connect to the existing server, or spawns new if not running. | ||||
| fn try_connect(self) -> impl Future<Item = (Self, UnixClient), Error = io::Error> { | fn try_connect(self) -> impl Future<Item = (Self, UnixClient), Error = io::Error> { | ||||
| debug!("try connect to {}", self.base_sock_path.display()); | debug!("try connect to {}", self.base_sock_path.display()); | ||||
| UnixClient::connect(self.base_sock_path.clone()).then(|res| match res { | UnixClient::connect(self.base_sock_path.clone()) | ||||
| .then(|res| match res { | |||||
| Ok(client) => Either::A(future::ok((self, client))), | Ok(client) => Either::A(future::ok((self, client))), | ||||
| Err(_) => Either::B(self.spawn_connect()), | Err(_) => Either::B(self.spawn_connect()), | ||||
| }) | }) | ||||
| .and_then(|(loc, client)| { | |||||
| check_server_capabilities(client.server_spec())?; | |||||
| Ok((loc, client)) | |||||
| }) | |||||
| } | } | ||||
| /// Spawns new server process and connects to it. | /// Spawns new server process and connects to it. | ||||
| /// | /// | ||||
| /// The server will be spawned at the current working directory, then | /// The server will be spawned at the current working directory, then | ||||
| /// chdir to "/", so that the server will load configs from the target | /// chdir to "/", so that the server will load configs from the target | ||||
| /// repository. | /// repository. | ||||
| fn spawn_connect(self) -> impl Future<Item = (Self, UnixClient), Error = io::Error> { | fn spawn_connect(self) -> impl Future<Item = (Self, UnixClient), Error = io::Error> { | ||||
| { | { | ||||
| let a = fs::symlink_metadata(path.as_ref())?; | let a = fs::symlink_metadata(path.as_ref())?; | ||||
| if a.is_dir() && a.uid() == procutil::get_effective_uid() && (a.mode() & 0o777) == 0o700 { | if a.is_dir() && a.uid() == procutil::get_effective_uid() && (a.mode() & 0o777) == 0o700 { | ||||
| Ok(path) | Ok(path) | ||||
| } else { | } else { | ||||
| Err(io::Error::new(io::ErrorKind::Other, "insecure directory")) | Err(io::Error::new(io::ErrorKind::Other, "insecure directory")) | ||||
| } | } | ||||
| } | } | ||||
| fn check_server_capabilities(spec: &ServerSpec) -> io::Result<()> { | |||||
| let unsupported: Vec<_> = REQUIRED_SERVER_CAPABILITIES | |||||
| .iter() | |||||
| .cloned() | |||||
| .filter(|&s| !spec.capabilities.contains(s)) | |||||
| .collect(); | |||||
| if unsupported.is_empty() { | |||||
| Ok(()) | |||||
| } else { | |||||
| let msg = format!( | |||||
| "insufficient server capabilities: {}", | |||||
| unsupported.join(", ") | |||||
| ); | |||||
| Err(io::Error::new(io::ErrorKind::Other, msg)) | |||||
| } | |||||
| } | |||||