This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8393

revset: rename generationsrel() to generationssubrel()
ClosedPublic

Authored by av6 on Apr 10 2020, 1:02 PM.

Details

Reviewers
yuja
Group Reviewers
hg-reviewers
Commits
rHG8859de3e83dc: revset: rename generationsrel() to generationssubrel()
Summary

This highlights that this is an implementation of 'x#y[z]' relation subscript
operator as opposed to 'x#y' relation operator.

Diff Detail

Repository
rHG Mercurial
Branch
default
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

av6 created this revision.Apr 10 2020, 1:02 PM
av6 added a commit: rHG8859de3e83dc: revset: rename generationsrel() to generationssubrel().Apr 15 2020, 11:18 AM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG8859de3e83dc: revset: rename generationsrel() to generationssubrel() (authored by av6). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/revset.py (6 lines)

Diff 21027

mercurial/revset.py

ancdepths = (0, 1) ancdepths = (0, 1)
if a < 0: if a < 0:
ancdepths = (-min(b, 0), -a + 1) ancdepths = (-min(b, 0), -a + 1)
if b > 0: if b > 0:
descdepths = (max(a, 0), b + 1) descdepths = (max(a, 0), b + 1)
return ancdepths, descdepths return ancdepths, descdepths
def generationsrel(repo, subset, x, rel, z, order): def generationssubrel(repo, subset, x, rel, z, order):
# TODO: rewrite tests, and drop startdepth argument from ancestors() and # TODO: rewrite tests, and drop startdepth argument from ancestors() and
# descendants() predicates # descendants() predicates
a, b = getintrange( a, b = getintrange(
z, z,
_(b'relation subscript must be an integer or a range'), _(b'relation subscript must be an integer or a range'),
_(b'relation subscript bounds must be integers'), _(b'relation subscript bounds must be integers'),
deffirst=-(dagop.maxlogdepth - 1), deffirst=-(dagop.maxlogdepth - 1),
deflast=+(dagop.maxlogdepth - 1), deflast=+(dagop.maxlogdepth - 1),
b"func": func, b"func": func,
b"ancestor": ancestorspec, b"ancestor": ancestorspec,
b"parent": parentspec, b"parent": parentspec,
b"parentpost": parentpost, b"parentpost": parentpost,
b"smartset": rawsmartset, b"smartset": rawsmartset,
} }
subscriptrelations = { subscriptrelations = {
b"g": generationsrel, b"g": generationssubrel,
b"generations": generationsrel, b"generations": generationssubrel,
} }
def lookupfn(repo): def lookupfn(repo):
return lambda symbol: scmutil.isrevsymbol(repo, symbol) return lambda symbol: scmutil.isrevsymbol(repo, symbol)
def match(ui, spec, lookup=None): def match(ui, spec, lookup=None):