( )⚙ D83 match: make base matcher return True for visitdir

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D83

match: make base matcher return True for visitdir
ClosedPublic

Authored by durham on Jul 14 2017, 1:57 PM.

Details

Reviewers
martinvonz
Group Reviewers
hg-reviewers
Commits
rHGcf15c3cc304c: match: make base matcher return True for visitdir
Summary

If a matcher doesn't implement visitdir, we should be returning True so that
tree traversals are not prematurely pruned. The old value of False would prevent
tree traversals when using any matcher that didn't implement visitdir.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

durham created this revision.Jul 14 2017, 1:57 PM
martinvonz accepted this revision.Jul 14 2017, 2:04 PM

Thanks. I had been thinking of making this change. I agree it's better to be slow but correct by default.

This revision is now accepted and ready to land.Jul 14 2017, 2:04 PM
Closed by commit rHGcf15c3cc304c: match: make base matcher return True for visitdir (authored by durham). · Explain WhyJul 14 2017, 11:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/match.py (2 lines)

Diff 149

mercurial/match.py

Returns the string 'all' if the given directory and all subdirectories Returns the string 'all' if the given directory and all subdirectories
should be visited. Otherwise returns True or False indicating whether should be visited. Otherwise returns True or False indicating whether
the given directory should be visited. the given directory should be visited.
This function's behavior is undefined if it has returned False for This function's behavior is undefined if it has returned False for
one of the dir's parent directories. one of the dir's parent directories.
''' '''
return False return True
def always(self): def always(self):
'''Matcher will match everything and .files() will be empty -- '''Matcher will match everything and .files() will be empty --
optimization might be possible.''' optimization might be possible.'''
return False return False
def isexact(self): def isexact(self):
'''Matcher will match exactly the list of files in .files() -- '''Matcher will match exactly the list of files in .files() --