This is an archive of the discontinued Mercurial Phabricator instance.

Differential D845

perf: remove fallbacks to ancient versions of dirstate.walk()
ClosedPublic

Authored by martinvonz on Sep 29 2017, 5:53 PM.

Details

Reviewers
quark
Group Reviewers
hg-reviewers
Commits
rHGb3538c03a804: perf: remove fallbacks to ancient versions of dirstate.walk()
Summary

If the call to dirstate.walk() failed, we would try to fall back to
older versions. These were removed in d3d1d39da2fa (walk: remove
cmdutil.walk, 2008-05-12) and f8299c84b5b6 (dirstate: fold statwalk
and walk, 2008-06-26). We don't care about testing performance of
versions that old versions at this point, so let's clean up.

Diff Detail

Repository
rHG Mercurial
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

martinvonz created this revision.Sep 29 2017, 5:53 PM
quark accepted this revision.Sep 29 2017, 10:03 PM
quark added a subscriber: quark.

I have confirmed that we only need to support changes introduced after Nov 2008.

Closed by commit rHGb3538c03a804: perf: remove fallbacks to ancient versions of dirstate.walk() (authored by martinvonz). · Explain WhySep 30 2017, 2:27 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mcontrib/perf.py (11 lines)

Diff 2165

contrib/perf.py

delattr(unfi, attrname) delattr(unfi, attrname)
unfi._filecache.pop(attrname, None) unfi._filecache.pop(attrname, None)
# perf commands # perf commands
@command('perfwalk', formatteropts) @command('perfwalk', formatteropts)
def perfwalk(ui, repo, *pats, **opts): def perfwalk(ui, repo, *pats, **opts):
timer, fm = gettimer(ui, opts) timer, fm = gettimer(ui, opts)
try:
m = scmutil.match(repo[None], pats, {}) m = scmutil.match(repo[None], pats, {})
timer(lambda: len(list(repo.dirstate.walk(m, [], True, False)))) timer(lambda: len(list(repo.dirstate.walk(m, [], True, False))))
except Exception:
try:
m = scmutil.match(repo[None], pats, {})
timer(lambda: len([b for a, b, c in repo.dirstate.statwalk([], m)]))
except Exception:
timer(lambda: len(list(cmdutil.walk(repo, pats, {}))))
fm.end() fm.end()
@command('perfannotate', formatteropts) @command('perfannotate', formatteropts)
def perfannotate(ui, repo, f, **opts): def perfannotate(ui, repo, f, **opts):
timer, fm = gettimer(ui, opts) timer, fm = gettimer(ui, opts)
fc = repo['.'][f] fc = repo['.'][f]
timer(lambda: len(fc.annotate(True))) timer(lambda: len(fc.annotate(True)))
fm.end() fm.end()