Page MenuHomePhabricator

fastexport: adjust output to be more canonical
ClosedPublic

Authored by joerg.sonnenberger on Apr 27 2020, 3:55 PM.

Details

Summary

The real name part of the committer name is normally not quoted, so
don't enforce that. Prefer UTC+0 to UTC-0, git doesn't normalize it.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

marmoute accepted this revision.Apr 28 2020, 4:24 AM
This revision was not accepted when it landed; it landed in state Needs Review.
This revision was automatically updated to reflect the committed changes.
martinvonz added inline comments.
hgext/fastexport.py
56

It looks like this not only changed the treatment of utcoff == 0 but completely negated it. Is that how it should be? We don't seem to have any tests with non-zero utcoff...

martinvonz added inline comments.Tue, May 12, 1:08 PM
hgext/fastexport.py
56

It's a trivial fix that I could of course easily do in flight, but I'd at least like a confirmation first. I'll instead drop this patch for now.