( )⚙ D8507 rust-regex: prevent nonsensical `.*.*` pattern from happening

This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8507

rust-regex: prevent nonsensical `.*.*` pattern from happening
ClosedPublic

Authored by Alphare on May 7 2020, 6:16 PM.

Details

Reviewers
indygreg
Group Reviewers
hg-reviewers
Commits
rHG1e9bfeaec9ba: rust-regex: prevent nonsensical `.*.*` pattern from happening
rHGdbc2dcbdd177: rust-regex: prevent nonsensical `.*.*` pattern from happening

Diff Detail

Repository
rHG Mercurial
Branch
stable
Lint
No Linters Available
Unit
No Unit Test Coverage

Revision Contents
Changeset List

PathPackages
Mrust/hg-core/src/filepatterns.rs (5 lines)

Diff 21321

rust/hg-core/src/filepatterns.rs

return [&pattern[..], b".*"].concat(); return [&pattern[..], b".*"].concat();
} }
[b".*", &pattern[..], b".*"].concat() [b".*", &pattern[..], b".*"].concat()
} }
PatternSyntax::RelRegexp => { PatternSyntax::RelRegexp => {
// The `regex` crate accepts `**` while `re2` and Python's `re` // The `regex` crate accepts `**` while `re2` and Python's `re`
// do not. Checking for `*` correctly triggers the same error all // do not. Checking for `*` correctly triggers the same error all
// engines. // engines.
if pattern[0] == b'^' || pattern[0] == b'*' { if pattern[0] == b'^'
|| pattern[0] == b'*'
|| pattern.starts_with(b".*")
{
return pattern.to_owned(); return pattern.to_owned();
} }
[&b".*"[..], pattern].concat() [&b".*"[..], pattern].concat()
} }
PatternSyntax::Path | PatternSyntax::RelPath => { PatternSyntax::Path | PatternSyntax::RelPath => {
if pattern == b"." { if pattern == b"." {
return vec![]; return vec![];
} }