This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8509

formatting: add missing newline
ClosedPublic

Authored by Alphare on May 7 2020, 7:20 PM.

Details

Reviewers
marmoute
Group Reviewers
hg-reviewers
Commits
rHG79f6f856c53f: formatting: add missing newline
rHG4be0cc3458e1: formatting: add missing newline

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Alphare created this revision.May 7 2020, 7:20 PM
marmoute accepted this revision.May 9 2020, 3:13 PM
marmoute added a subscriber: marmoute.

Thanks for fixinf this, all our CI is on fire :-/

Alphare added a commit: rHG4be0cc3458e1: formatting: add missing newline.May 9 2020, 4:26 PM
This revision was not accepted when it landed; it landed in state Needs Review.
Closed by commit rHG4be0cc3458e1: formatting: add missing newline (authored by Alphare). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmercurial/utils/procutil.py (1 line)

Diff 21329

mercurial/utils/procutil.py

if not ensurestart: if not ensurestart:
# Even though we're not waiting on the child process, # Even though we're not waiting on the child process,
# we still must call waitpid() on it at some point so # we still must call waitpid() on it at some point so
# it's not a zombie/defunct. This is especially relevant for # it's not a zombie/defunct. This is especially relevant for
# chg since the parent process won't die anytime soon. # chg since the parent process won't die anytime soon.
# We use a thread to make the overhead tiny. # We use a thread to make the overhead tiny.
def _do_wait(): def _do_wait():
os.waitpid(pid, 0) os.waitpid(pid, 0)
threading.Thread(target=_do_wait, daemon=True).start() threading.Thread(target=_do_wait, daemon=True).start()
return return
# Parent process # Parent process
(_pid, status) = os.waitpid(pid, 0) (_pid, status) = os.waitpid(pid, 0)
if os.WIFEXITED(status): if os.WIFEXITED(status):
returncode = os.WEXITSTATUS(status) returncode = os.WEXITSTATUS(status)
else: else:
returncode = -(os.WTERMSIG(status)) returncode = -(os.WTERMSIG(status))