Page MenuHomePhabricator

flags: read flag from dirstate/disk for workingcopyctx (issue5743)
ClosedPublic

Authored by marmoute on Sat, May 16, 4:11 PM.

Details

Summary

In 491855ea9d62, various piece of code are moved from committablectx to
workingctx. The reason given is "These read from the dirstate, so they shouldn't
be used in other subclasses."

At least for flags this change introduce a bug, because the value flags end up being
read from _manifest disregarding the actual state in the working copy (ie: on
disk). When merging exec flag change with renames, this means a new files (the
local content, renamed) is properly written on disk, with the right flags, but
the flags part is later ignored when actually reading flags during merge.

It is not clear to me why the flags function was moved, because the code does
not actually hit the dirstate (the reason given in the changeset description).
So I am moving it back to were it comes from and we use a simpler version of
that code (that hit the dirstate everytime) in workingcopyctx. This fix the last
know bug with merging rename and executable byte changes.

Other similar bug might be lurking in 491855ea9d62, but I have not investigated
them.

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.