This is an archive of the discontinued Mercurial Phabricator instance.

Differential D8539

git: fix probable missing return
ClosedPublic

Authored by rom1dep on May 17 2020, 1:39 PM.

Details

Reviewers
durin42
pulkit
Group Reviewers
hg-reviewers
Commits
rHG288328c6711b: git: fix probable missing return

Diff Detail

Repository
rHG Mercurial
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rom1dep created this revision.May 17 2020, 1:39 PM
pulkit accepted this revision.May 17 2020, 4:47 PM
This revision is now accepted and ready to land.May 17 2020, 4:47 PM
rom1dep added a commit: rHG288328c6711b: git: fix probable missing return.May 17 2020, 5:18 PM
Closed by commit rHG288328c6711b: git: fix probable missing return (authored by rom1dep). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhgext/git/manifest.py (2 lines)

Diff 21410

hgext/git/manifest.py

return self.read() return self.read()
def copy(self): def copy(self):
# NB: it's important that we return a memgittreemanifestctx # NB: it's important that we return a memgittreemanifestctx
# because the caller expects a mutable manifest. # because the caller expects a mutable manifest.
return memgittreemanifestctx(self._repo, self._tree) return memgittreemanifestctx(self._repo, self._tree)
def find(self, path): def find(self, path):
self.read()[path] return self.read()[path]
@interfaceutil.implementer(repository.imanifestrevisionwritable) @interfaceutil.implementer(repository.imanifestrevisionwritable)
class memgittreemanifestctx(object): class memgittreemanifestctx(object):
def __init__(self, repo, tree): def __init__(self, repo, tree):
self._repo = repo self._repo = repo
self._tree = tree self._tree = tree
# dict of path: Optional[Tuple(node, flags)] # dict of path: Optional[Tuple(node, flags)]